-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rtd pull request preview git diff #681
Conversation
…and use globbing for `.rst` files
Pull Request Test Coverage Report for Build 9770209385Details
💛 - Coveralls |
…e are changes in the docs
Pull Request Test Coverage Report for Build 9770341770Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9770352781Details
💛 - Coveralls |
A link to a preview build will not show up in this PR, but will in future PRs. |
Pull Request Test Coverage Report for Build 9772285057Details
💛 - Coveralls |
I should note that the link appears in the PR description if and only if there are changed docs when the PR is opened, and not on subsequent pushes to the PR. See readthedocs/actions#41 |
@@ -24,7 +24,7 @@ build: | |||
# If there are no changes (git diff exits with 0) we force the command to return with 183. | |||
# This is a special exit code on Read the Docs that will cancel the build immediately. | |||
- | | |||
if [ "$READTHEDOCS_VERSION_TYPE" = "external" ] && git diff --quiet origin/main -- docs/ src/icalender/*.py CHANGES.rst CONTRIBUTING.rst LICENSE.rst README.rst .readthedocs.yaml requirements_docs.txt; | |||
if [ "$READTHEDOCS_VERSION_TYPE" = "external" ] && git diff --quiet origin/main -- . docs/ src/icalendar/*.py *.rst .readthedocs.yaml requirements_docs.txt ':!src/icalendar/fuzzing' ':!src/icalendar/tests' ':!src/icalendar/timezone'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you diff .
, then this is for everything... Ah and I see the exclude... cool. I did not know that was possible. ❤️ I learned something!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the .
, nothing would be included. There may be other improvements, but this is what worked for me.
No description provided.